netdev - Re: [PATCH net-next 2/2] rocker: mark parameters and local variables as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150513063713.GA23718@verge.net.au>
Date:	Wed, 13 May 2015 15:37:13 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Simon Horman <simon.horman@...ronome.com>,
	Jiri Pirko <jiri@...nulli.us>,
	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] rocker: mark parameters and local variables
 as const

On Tue, May 12, 2015 at 11:25:47PM -0700, Scott Feldman wrote:
> On Tue, May 12, 2015 at 10:52 PM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> > Mark parameters and local variables as const where possible.
> >
> > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> > ---
> >  drivers/net/ethernet/rocker/rocker.c | 258 ++++++++++++++++++-----------------
> >  1 file changed, 136 insertions(+), 122 deletions(-)
> >
> 
> [cut]
> 
> > @@ -4833,7 +4847,7 @@ static int rocker_port_poll_rx(struct napi_struct *napi, int budget)
> >
> >  static void rocker_carrier_init(struct rocker_port *rocker_port)
> 
> Why are some left un-const, like above?

For some reason I didn't address the PCI driver ops.
I'll do another pass.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html