netdev - Re: [PATCH -next v3] net: core: set qdisc pkt len before tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5553E7E0.8040107@mojatatu.com>
Date:	Wed, 13 May 2015 20:10:08 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Florian Westphal <fw@...len.de>
CC:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH -next v3] net: core: set qdisc pkt len before tc_classify

On 05/13/15 19:54, Alexei Starovoitov wrote:
> On Thu, May 14, 2015 at 12:36:28AM +0200, Florian Westphal wrote:
>> commit d2788d34885d4ce5ba ("net: sched: further simplify handle_ing")
>> removed the call to qdisc_enqueue_root().
>>
>> However, after this removal we no longer set qdisc pkt length.
>> This breaks traffic policing on ingress.
>>
>> This is the minimum fix: set qdisc pkt length before tc_classify.
>
> Thanks!
> Acked-by: Alexei Starovoitov <ast@...mgrid.com>
>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

PS:- dont agree with the statement that policer is rarely used
on ingress.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html