netdev - Re: netlink & rhashtable status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150514025557.GB3853@gondor.apana.org.au>
Date:	Thu, 14 May 2015 10:55:57 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: netlink & rhashtable status

On Wed, May 13, 2015 at 12:35:20PM -0400, David Miller wrote:
>
> Alternatively, we could consider reverting the rhashtable conversion
> of netlink in the interim.  It might be the safest solution for
> -stable.

The most suspicous change is the dynamic rehashing, i.e., allowing
insertions/removals during a rehash.  But then Eric says that the
same thing happens under 3.17, where every opertion is under a
single mutex.

So I'm at a loss as to what is wrong and if we can't figure it out
then yes I agree that reverting the netlink rhashtable conversion is
probably the safest option.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html