netdev - Re: [PATCH v2] cls_flower: Fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 May 2015 13:02:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	brian.haley@...com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH v2] cls_flower: Fix compile error

From: Brian Haley <brian.haley@...com>
Date: Thu, 14 May 2015 12:50:17 -0400

> Fix compile error in net/sched/cls_flower.c
> 
>     net/sched/cls_flower.c: In function ‘fl_set_key’:
>     net/sched/cls_flower.c:240:3: error: implicit declaration of function
>     ‘tcf_change_indev’ [-Werror=implicit-function-declaration]
>        err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
> 
> Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641
> 
> Signed-off-by: Brian Haley <brian.haley@...com>
> 
> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
> index 9bc654c..8c8f34e 100644
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
>  static int fl_set_key(struct net *net, struct nlattr **tb,
>  		      struct fl_flow_key *key, struct fl_flow_key *mask)
>  {
> -	int err;
> -

This patch is corrupted by your email client.

Also, referring to a guilty patch is done using the "Fixes: " tag
which should appear right before your signoff.  It is to be of
the form:

Fixes: $(SHA1_ID) ("Commit summary line text")

The SHA1_ID should be of 12 characters of significance.