netdev - Re: [PATCH V2 0/5] e1000e: fix nic not boot after rebooting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150514171022.GA27968@1wt.eu>
Date:	Thu, 14 May 2015 19:10:22 +0200
From:	Willy Tarreau <w@....eu>
To:	Zhu Yanjun <zyjzyj2000@...il.com>
Cc:	netdev@...r.kernel.org, Zhu Yanjun <Yanjun.Zhu@...driver.com>
Subject: Re: [PATCH V2 0/5] e1000e: fix nic not boot after rebooting

Hi,

On Tue, Dec 16, 2014 at 06:28:15PM +0800, Zhu Yanjun wrote:
> With kernel 2.6.x, e1000e with 82577/8/9 sometimes will not boot
> after rebooting. 
> 
> If a kernel 2.6.x board with 82577/8/9 e1000e nic is rebooted for 
> 100 times, there are 7~8 times that 82577/8/9 e1000e nic will not boot 
> normally.
> 
> V2:
> Follow the advice from Willy, the wrong upstream commit IDs in these
> 5 patches commit messages are fixed.
> 
> Zhu Yanjun (5):
>   e1000e: reset MAC-PHY interconnect on 82577/82578
>   e1000e: workaround EEPROM configuration change on 82579 on kernel
>     2.6.x
>   e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked
>   e1000e: update workaround for 82579 intermittently disabled during
>     S0->Sx
>   e1000e: cleanup use of check_reset_block function pointer

I queued this series for 2.6.32.66 but found that it doesn't build
because patch 2 adds this test :

@@ -2685,6 +2694,14 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw)
        ew32(CTRL, (ctrl | E1000_CTRL_RST));                            
        msleep(20);

+       /* Set Phy Config Counter to 50msec */
+       if (hw->mac.type == e1000_pch2lan) {
+               u32 phycc_reg = er32(FEXTNVM3);
+               phycc_reg &= ~E1000_FEXTNVM3_PHY_CFG_COUNTER_MASK;
+               phycc_reg |= E1000_FEXTNVM3_PHY_CFG_COUNTER_50MSEC;
+               ew32(FEXTNVM3, phycc_reg);
+       }
+

And e1000_pch2lan doesn't appear in the enum in 2.6.32 hence this
type is never assigned. Thus I'm wondering if I should just drop
this test (trivial) or if there are other parts that may not be
relevant to this kernel version.

Any hint will be greatly appreciated.

Thanks!
Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html