netdev - Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 May 2015 11:28:33 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com,
	tgraf@...g.ch, davem@...emloft.net
Subject: Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting
 skb->dev in receive path

On Wed, May 13, 2015 at 07:04:28PM -0700, Alexander Duyck wrote:
> This change makes it so that we clear the skb->mark field when we pass
> through the receive path of the IPv4 or IPv6 virtual tunnel interface.  The
> reason for clearing these fields is to resolve an apparent regression for
> the behavior before skb_scrub_packet was modified.  Without this patch I
> have to set disable_policy for the vti tunnel endpoint in order to be able
> to receive traffic.
> 
> Fixes: 213dd74aee76 ("skbuff: Do not scrub skb mark within the same name space")
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>

This patch makes no sense.  Please explain your problem more
clearly and tell us why the mark changes the way your packet
is dealt with and why this isn't a policy decision that should
be made in user-space.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html