netdev - Re: [PATCH] fix net/sched compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5554FDF7.7010406@cogentembedded.com>
Date:	Thu, 14 May 2015 22:56:39 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Brian Haley <brian.haley@...com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Jiri Pirko <jiri@...nulli.us>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] fix net/sched compile error

Hello.

On 05/14/2015 07:33 PM, Brian Haley wrote:

> Fix compile error in net/sched/cls_flower.c

>      net/sched/cls_flower.c: In function ‘fl_set_key’:
>      net/sched/cls_flower.c:240:3: error: implicit declaration of function
> ‘tcf_change_indev’ [-Werror=implicit-function-declaration]
>         err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

> Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641

> Signed-off-by: Brian Haley <brian.haley@...com>

> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
> index 9bc654c..8c8f34e 100644
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
>   static int fl_set_key(struct net *net, struct nlattr **tb,
>                 struct fl_flow_key *key, struct fl_flow_key *mask)
>   {
> -    int err;
> -
> +#ifdef CONFIG_NET_CLS_IND
>       if (tb[TCA_FLOWER_INDEV]) {
> -        err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
> +        int err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

    Empty line needed here.

>           if (err < 0)
>               return err;
>           key->indev_ifindex = err;
>           mask->indev_ifindex = 0xffffffff;
>       }
> +#endif
[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html