netdev - Re: [PATCH] vlan: Correctly propagate promisc|allmulti flags in notifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150514.005540.60193741590743501.davem@davemloft.net>
Date:	Thu, 14 May 2015 00:55:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net, vyasevic@...hat.com
Subject: Re: [PATCH] vlan: Correctly propagate promisc|allmulti flags in
 notifier.

From: Vladislav Yasevich <vyasevich@...il.com>
Date: Tue, 12 May 2015 20:53:14 -0400

> Currently vlan notifier handler will try to update all vlans
> for a device when that device comes up.  A problem occurs,
> however, when the vlan device was set to promiscuous, but not
> by the user (ex: a bridge).  In that case, dev->gflags are
> not updated.  What results is that the lower device ends
> up with an extra promiscuity count.  Here are the
> backtraces that prove this:
 ...
> The above comes from the setting the vlan device to IFF_UP state.
 ...
> And this one comes from the notification code.  What we end
> up with is a vlan with promiscuity count of 1 and and a physical
> device with a promiscuity count of 2.  They should both have
> a count 1.
> 
> To resolve this issue, vlan code can use dev_get_flags() api
> which correctly masks promiscuity and allmulti flags.

Applied, thanks Vlad.

> Sign-off-by: Vlad Yasevich <vyasevic@...hat.com>

Note, it's "Signed-off-by:" not "Sign-off-by:" I fixed this for
you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html