lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 May 2015 09:23:21 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Florian Westphal <fw@...len.de> Cc: netdev@...r.kernel.org, jhs@...atatu.com, daniel@...earbox.net Subject: Re: [PATCH -next 2/3] net: sched: remove AT INGRESS/EGRESS On Fri, May 15, 2015 at 10:50:49AM +0200, Florian Westphal wrote: > > enum skb_tc_state { > + TC_NO_STATE = 0, /* must be 0 */ > + > /* set by act_mirred to tell IFB that skb needs to be ... */ > TC_FROM_INGRESS = 1, /* ... re-injected to local stack */ > TC_FROM_EGRESS = 2, /* ... transmitted to device */ > + > + /* used by act_mirred to learn its called during skb rx processing > + * and has to push back the (already pulled) l2 header. > + */ > + TC_AT_INGRESS = 3, > }; > ... > diff --git a/net/core/dev.c b/net/core/dev.c > index 0e7afef..802b9b9 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -3071,9 +3071,6 @@ static int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv) > txq = netdev_pick_tx(dev, skb, accel_priv); > q = rcu_dereference_bh(txq->qdisc); > > -#ifdef CONFIG_NET_CLS_ACT > - skb->tc_verd = SET_TC_AT(skb->tc_verd, AT_EGRESS); > -#endif I don't think it's a good change. Squeezing 4 bits into 2 by losing AT_STACK condition, imo, is wrong. Before ifb could differentiate AT_STACK and AT_EGRESS, but when they're aliased we lose this information. I think we should keep AT_STACK, AT_INGRESS, AT_EGRESS. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists