lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 May 2015 11:01:54 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...hat.com> Cc: herbert@...dor.apana.org.au, tgraf@...g.ch, netdev@...r.kernel.org, ying.xue@...driver.com Subject: Re: netlink: Kill bogus lock_sock in netlink_insert On Fri, 2015-05-15 at 12:49 -0400, David Miller wrote: > From: Herbert Xu <herbert@...dor.apana.org.au> > Date: Thu, 14 May 2015 14:02:30 +0800 > > > On Thu, May 14, 2015 at 01:58:24PM +0800, Herbert Xu wrote: > >> > >> This patch also removes a bogus socket lock introduced by that > >> very same patch. > > > > This bogus socket lock is still there in the current tree. > > > > ---8<--- > > The commit c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: > > eliminate nl_sk_hash_lock") added a lock_sock to netlink_insert > > with no justifications whatsoever. > > > > This patch kills it. > > > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> > > Eric, does this improve your benchmark? I don't think so, but I can test this in about one hour. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists