netdev - Re: [PATCH] netfilter: ipset: deinline ip_set_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1505152204330.29442@blackhole.kfki.hu>
Date:	Fri, 15 May 2015 22:05:44 +0200 (CEST)
From:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To:	Pablo Neira Ayuso <pablo@...filter.org>
cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Jiri Pirko <jpirko@...hat.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions()

On Thu, 14 May 2015, Pablo Neira Ayuso wrote:

> On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote:
> > On x86 allyesconfig build:
> > The function compiles to 489 bytes of machine code.
> > It has 25 callsites.
> > 
> >     text    data       bss       dec     hex filename
> > 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before
> > 82434909 22255384 20627456 125317749 7783275 vmlinux
> 
> Jozsef, I'm going to applied this patch to nf-next.

Thanks!

> I think that things like ip_set_put_skbinfo() can be also deinlined
> and move to the core as exported symbol as this run from the control
> plane path (ie. netlink).

I'll add the patch for that to the next round of the ipset patches.

Best regards,
Jozsef
-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html