netdev - Re: [PATCH net-next v2] rocker: fix a neigh entry leak issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55555A3A.6030201@windriver.com>
Date:	Fri, 15 May 2015 10:30:18 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <eric.dumazet@...il.com>,
	<jiri@...nulli.us>, <sfeldma@...il.com>
Subject: Re: [PATCH net-next v2] rocker: fix a neigh entry leak issue

On 05/15/2015 10:26 AM, David Miller wrote:
> From: Ying Xue <ying.xue@...driver.com>
> Date: Fri, 15 May 2015 09:33:25 +0800
> 
>> Once we get a neighbour through looking up arp cache or creating a
>> new one in rocker_port_ipv4_resolve(), the neighbour's refcount is
>> already taken. But as we don't put the refcount again after it's
>> used, this makes the neighbour entry leaked.
>>
>> Suggested-by: Eric Dumazet <edumazet@...gle.com>
>> Acked-by: Jiri Pirko <jiri@...nulli.us>
>> Signed-off-by: Ying Xue <ying.xue@...driver.com>
>> ---
>> v2:
>>   Add the checking of return value of neigh_create() with IS_ERR()
>>   to avoid another crash, which is suggested by Eric Dumazet.
> 
> Doesn't this leak exist in the 'net' tree?
> 
> If so, why are you targetting such a bug fix for 'net-next'?
> 
> 

Sorry, I am used to develop in net-next tree. Please wait a moment, I will check
whether the issue also exists in net tree.

Regards,
Ying

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html