netdev - Re: [PATCH net-next,v2,1/1] hv_netvsc: use per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150514.224958.144644873953606975.davem@davemloft.net>
Date:	Thu, 14 May 2015 22:49:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sixiao@...rosoft.com
Cc:	kys@...rosoft.com, haiyangz@...rosoft.com,
	devel@...uxdriverproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next,v2,1/1] hv_netvsc: use per_cpu stats to
 calculate TX/RX data

From: Simon Xiao <sixiao@...rosoft.com>
Date: Thu, 14 May 2015 01:00:25 -0700

> Current code does not lock anything when calculating the TX and RX stats.
> As a result, the RX and TX data reported by ifconfig are not accuracy in a
> system with high network throughput and multiple CPUs (in my test,
> RX/TX = 83% between 2 HyperV VM nodes which have 8 vCPUs and 40G Ethernet).
> 
> This patch fixed the above issue by using per_cpu stats.
> netvsc_get_stats64() summarizes TX and RX data by iterating over all CPUs
> to get their respective stats.
> 
> This v2 patch addressed David's comments on the cleanup path when
> netdev_alloc_pcpu_stats() failed.
> 
> Signed-off-by: Simon Xiao <sixiao@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html