netdev - Re: [PATCH net-next] be2net: be_hwmon_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 May 2015 13:19:21 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	ying.xue@...driver.com, kbuild-all@...org,
	sathya.perla@...gotech.com, ajit.khaparde@...gotech.com,
	padmanabh.ratnakar@...gotech.com,
	sriharsha.basavapatna@...gotech.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] be2net: be_hwmon_show_temp() can be static

On Thu, May 14, 2015 at 05:39:46PM -0400, David Miller wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> Date: Fri, 15 May 2015 03:02:35 +0800
> 
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > ---
> >  be_main.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> > index dc7c0fd..76d491f 100644
> > --- a/drivers/net/ethernet/emulex/benet/be_main.c
> > +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> > @@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
> >  	free_netdev(adapter->netdev);
> >  }
> >  
> > -ssize_t be_hwmon_show_temp(struct device *dev,
> > +static ssize_t be_hwmon_show_temp(struct device *dev,
> >  			   struct device_attribute *dev_attr,
> >  			   char *buf)
> 
> If you adjust the column of the openning parenthesis of the
> function, you have to reindent the subsequent lines so that they
> start precisely at the very next column.
> 
> You must use the appropriate number of TAB and SPACE characters
> necessary to do so.

OK. We'll improve the script to adjust indent accordingly.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html