netdev - Re: [PATCH net-next 0/6] neigh cleanups and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431692082.27831.92.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 15 May 2015 05:14:42 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	netdev@...r.kernel.org, alexei@...estorage.com,
	joern@...estorage.com, ja@....bg, davem@...emloft.net
Subject: Re: [PATCH net-next 0/6] neigh cleanups and fixes

On Fri, 2015-05-15 at 14:55 +0800, Ying Xue wrote:
> The series aims to clean up several mistakes especially to correct
> the usage of neigh timer. But before doing them, we have to resolve
> a crash issue discussed in the thread[1].
> 
> [1] http://www.spinics.net/lists/netdev/msg323883.html
> 
> Ying Xue (6):
>   net: fix a double free issue for neighbour entry
>   neigh: fix a possible leak issue of neigh entry
>   neigh: don't delete neighbour time in neigh_destroy
>   neigh: align the usage of neigh timer with one of sock timer
>   neigh: neigh dead and timer variables should be protected under its
>     lock
>   neigh: use standard interface to modify timer
> 
>  net/core/neighbour.c |   39 +++++++++++++++++++++++----------------
>  net/ipv4/ip_output.c |    2 +-
>  2 files changed, 24 insertions(+), 17 deletions(-)
> 

NACK for the whole series.

Your fixes make no sense, adding race conditions of all sorts.

atomic_read() by definition are unsafe.

Make a single and logical change, do not throw random patches like that,
ignoring feedback you already got.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html