netdev - Re: [PATCH 2/4] netfilter: avoid build error if TPROXY/SOCKET=y && NF_DEFRAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5557956F.9050508@cogentembedded.com>
Date:	Sat, 16 May 2015 22:07:27 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/4] netfilter: avoid build error if TPROXY/SOCKET=y &&
 NF_DEFRAG_IPV6=m

Hello.

On 05/16/2015 09:47 PM, Pablo Neira Ayuso wrote:

> From: Florian Westphal <fw@...len.de>

> With TPROXY=y but DEFRAG_IPV6=m we get build failure:

> net/built-in.o: In function `tproxy_tg_init':
> net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable'

> If DEFRAG_IPV6 is modular, TPROXY must be too.
> (or both must be builtin).

> This enforces =m for both.

> Reported-and-tested-by: Liu Hua <liusdu@....com>
> Signed-off-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>   net/netfilter/Kconfig |    2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index f70e34a..a0f3e6a3 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -863,6 +863,7 @@ config NETFILTER_XT_TARGET_TPROXY
>   	depends on NETFILTER_XTABLES
>   	depends on NETFILTER_ADVANCED
>   	depends on (IPV6 || IPV6=n)
> +	depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n)
>   	depends on IP_NF_MANGLE
>   	select NF_DEFRAG_IPV4
>   	select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES
> @@ -1356,6 +1357,7 @@ config NETFILTER_XT_MATCH_SOCKET
>   	depends on NETFILTER_ADVANCED
>   	depends on !NF_CONNTRACK || NF_CONNTRACK
>   	depends on (IPV6 || IPV6=n)
> +	depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n)

    Parens not needed here and in the previous hunk.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html