netdev - Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55592746.6020902@cumulusnetworks.com>
Date:	Sun, 17 May 2015 16:41:58 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	davem@...emloft.net, sfeldma@...il.com, john.fastabend@...il.com,
	jiri@...nulli.us
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload
 on failure to program fib entry in hardware

On 5/16/15, 8:46 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
> This patch removes the calls to netdev_switch_fib_ipv4_abort when
> there is an error in programming fib entry in hardware.
>
> On most systems where you can offload routes to hardware,
> doing routing in software is not an option (the cpu limitations
> make routing impossible in software).
>
> I understand that this was added to keep the first fib offload support
> simple.
>
> As discussed in the RFC patch, available options:
> a) Fail fib entry add on hardware offload failure on switch devices, and
> return appropriate error to the user by default (this patch)
> b) make the behaviour in a) conditional on a global flag/sysctl (a per fib
> entry flag will not work because by default user/routing-daemons dont care
> if they are hardware offloaded)
> c) for users/routing-daemons interested in controlling hardware
> offload behaviour there is always the per fib entry flag RTNH_F_OFFLOAD
>
> Considering the characteristics of the systems that support fib offloads,
> this patch implements a). Also making a) the default will enable easier/faster
> migration of existing routing apps to switch devices.
>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
> RFC to v1:
>    - rebase to net
>    - remove fib_offload_disabled flag and all associated code as suggested by
>      scott feldman
>
> (This patch is currently against net. If there is any reason to move it to
> net-next, I can respin)
>
>
pls ignore, i will be resending v2 with missing switchdev.h cleanups.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html