netdev - Re: [PATCH net-next] tcp: add rfc3168, section 6.1.1.1. fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431910796.621.7.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sun, 17 May 2015 17:59:56 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Florian Westphal <fw@...len.de>,
	Mirja Kühlewind 
	<mirja.kuehlewind@....ee.ethz.ch>,
	Brian Trammell <trammell@....ee.ethz.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Dave That <dave.taht@...il.com>
Subject: Re: [PATCH net-next] tcp: add rfc3168, section 6.1.1.1. fallback

On Sun, 2015-05-17 at 22:11 +0200, Daniel Borkmann wrote:

>  
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 7386d32..b05d6df 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -350,6 +350,16 @@ static void tcp_ecn_send_syn(struct sock *sk, struct sk_buff *skb)
>  	}
>  }
>  
> +static void tcp_ecn_clear_syn(struct sock *sk, struct sk_buff *skb)
> +{
> +	struct tcp_sock *tp = tcp_sk(sk);
> +
> +	if (sock_net(sk)->ipv4.sysctl_tcp_ecn_fallback) {
> +		TCP_SKB_CB(skb)->tcp_flags &= ~(TCPHDR_ECE | TCPHDR_CWR);
> +		tp->ecn_flags = 0;
> +	}
> +}
> +

Hi Daniel

If first SYNACK ECE was delayed (our SYN rtx was spurious), maybe we can
still keep ECN enabled ?

So maybe do not clear tp->ecn_flags here, as it should be ultimately
cleared in tcp_ecn_rcv_synack().





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html