netdev - Re: [PATCH net-next] net: dsa: bcm_sf2: properly propagate carrier down state for MoCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150517.234055.677371627234815683.davem@davemloft.net>
Date:	Sun, 17 May 2015 23:40:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, pgynther@...gle.com
Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: properly propagate carrier
 down state for MoCA

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 15 May 2015 12:38:01 -0700

> MoCA interfaces require the use of an user-space daemon (mocad) which
> will typically use cmd->autoneg to force the link. This is causing other
> network manager applications not to get proper carrier down
> notifications because of the following sequence of events:
> 
> - link down interrupt is received, link is set to 0 by the interrupt
>   handler
> - fixed_link update callback runs and updates the BMSR register
>   accordingly
> - PHY library polls the PHY for link status, sees the link is down,
>   proceeds with reporting that
> - mocad gets notified of the link state and call phy_ethtool_sset()
>   with cmd->autoneg set to the link status (0)
> - phy_start_aneg() is called at the end of phy_ethtool_sset() and sets
>   the PHY state to PHY_FORCING
> 
> Just make sure we notify the interface carrier appropriately when we
> detect that the link is down in our fixed_link update callback. This is
> made local to the bcm_sf2 driver as the PHY library does the right thing
> in any case. This is similar to the GENET change introduced in
> 54d7c01d3ed699cfc213115eaecfe1175cfaff8f ("net: bcmgenet: enable MoCA
> link state change detection").
> 
> Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html