netdev - Re: [PATCH net-next] net-packet: fix null pointer exception in rollover mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150517.224201.2115540798928063394.davem@davemloft.net>
Date:	Sun, 17 May 2015 22:42:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	willemb@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net-packet: fix null pointer exception in
 rollover mode

From: Willem de Bruijn <willemb@...gle.com>
Date: Sun, 17 May 2015 19:44:02 -0400

> Rollover can be enabled as flag or mode. Allocate state in both cases.
> This solves a NULL pointer exception in fanout_demux_rollover on
> referencing po->rollover if using mode rollover.
> 
> Also make sure that in rollover mode each silo is tried (contrary
> to rollover flag, where the main socket is excluded after an initial
> try_self).
> 
> Tested:
>   Passes tools/testing/net/psock_fanout.c, which tests both modes and
>   flag. My previous tests were limited to bench_rollover, which only
>   stresses the flag. The test now completes safely. it still gives an
>   error for mode rollover, because it does not expect the new headroom
>   (ROOM_NORMAL) requirement. I will send a separate patch to the test.
> 
> Fixes: 0648ab70afe6 ("packet: rollover prepare: per-socket state")
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Willem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html