netdev - Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518083843.GF8928@secunet.com>
Date:	Mon, 18 May 2015 10:38:44 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	David Miller <davem@...emloft.net>, <alexander.duyck@...il.com>,
	<alexander.h.duyck@...hat.com>, <netdev@...r.kernel.org>,
	<tgraf@...g.ch>
Subject: Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting
 skb->dev in receive path

On Mon, May 18, 2015 at 04:31:21PM +0800, Herbert Xu wrote:
> On Mon, May 18, 2015 at 09:04:27AM +0200, Steffen Klassert wrote:
> >
> > The policy and state mark must match the tunnels i_key/o_key
> > on lookup. It is not required to set skb->mark, but we have
> > to make sure to use the tunnels gre keys as the mark when we
> > do a policy or state lookup.
> 
> So is it possible to restore the original mark after the lookups?

Yes, that's possible. We just did not restore it because it 
was cleared with skb_scrub_packet() right after the lookup.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html