netdev - Re: [PATCH v4 for-next 03/12] IB/core: Find the network namespace matching connection parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 12:26:16 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Haggai Eran <haggaie@...lanox.com>
Cc:	Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, Liran Liss <liranl@...lanox.com>,
	Guy Shapiro <guysh@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Yotam Kenneth <yotamke@...lanox.com>
Subject: Re: [PATCH v4 for-next 03/12] IB/core: Find the network namespace
 matching connection parameters

> +	list_for_each_entry_rcu(client, &client_list, list)
> +		if (client->get_net_device_by_port_pkey_ip) {
> +			ret = client->get_net_device_by_port_pkey_ip(dev, port,
> +								     pkey,
> +
> addr);

Considering the patch that introduced the rwsem, this doesn't look
right.

We can't call a client call back on a device that is unregistered, we
can't call a client call back on a client that is unregistering.

So the ordering of the list_del/add vs call back calls in device.c is
not right, please audit everything with an eye toward maintaing sane
invarients.

Jason
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html