netdev - Re: [net-next PATCH 04/10] pktgen: document ability to add same device to several threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555BB105.8060307@plumgrid.com>
Date:	Tue, 19 May 2015 14:54:13 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org
CC:	Daniel Borkmann <borkmann@...earbox.net>,
	Robert Olsson <robert@...julf.se>,
	Ben Greear <greearb@...delatech.com>
Subject: Re: [net-next PATCH 04/10] pktgen: document ability to add same device
 to several threads

On 5/19/15 2:35 PM, Jesper Dangaard Brouer wrote:
> The pktgen.txt documentation still claimed that adding same device to
> multiple threads were not supported, but it have been since 2008 via
> commit e6fce5b916cd7 ("pktgen: multiqueue etc.").
>
> Document this and describe the naming scheme dev@X, as the procfile name
> still need to be unique.
>
> Fixes: e6fce5b916cd7 ("pktgen: multiqueue etc.")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
...
> -Most important are the devices assigned to the thread.  Note that a
> -device can only belong to one thread.
> +The two basic thread commands are:
> + * add_device DEVICE@...E -- adds a single device

Great work for the whole series!
Wanted to specifically
Acked-by: Alexei Starovoitov <ast@...mgrid.com>
this patch, since it could have saved me days of pointlessly
reimplementing existing feature and likely will help others
in the future. People do read docs :)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html