netdev - Re: [Xen-devel] [RFC PATCH 10/13] xen-netfront: refactor claim/release grant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DE282026-6084-415C-B948-E95635CFD545@neclab.eu>
Date:	Tue, 19 May 2015 10:19:24 +0000
From:	Joao Martins <Joao.Martins@...lab.eu>
To:	David Vrabel <david.vrabel@...rix.com>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"wei.liu2@...rix.com" <wei.liu2@...rix.com>,
	"ian.campbell@...rix.com" <ian.campbell@...rix.com>,
	"boris.ostrovsky@...cle.com" <boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [RFC PATCH 10/13] xen-netfront: refactor
 claim/release grant


On 18 May 2015, at 17:48, David Vrabel <david.vrabel@...rix.com> wrote:
> On 12/05/15 18:18, Joao Martins wrote:
>> Refactors how grants are claimed/released/revoked by moving that code
>> into claim_grant and release_grant helpers routines that can be shared
>> in both TX/RX path.
> 
> Reviewed-by: David Vrabel <david.vrabel@...rix.com>
> 
> But should this be generic?  Is it useful to other frontends?  And some
> of the line splitting looks a bit odd.

It looks like scsifront (lines 384-389, 418-423), blkfront (lines 250-257)
and netfront both grant their buffers in the same way, so perhaps these two
helpers could be reused.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html