netdev - Re: [PATCH] mac802154: select CRYPTO when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 14:57:08 +0200
From:	Stefan Schmidt <stefan@....samsung.com>
To:	Arnd Bergmann <arnd@...db.de>,
	Alexander Aring <alex.aring@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mac802154: select CRYPTO when needed

Hello.

On 19/05/15 14:18, Arnd Bergmann wrote:
> The mac802154 subsystem uses functions from the crypto layer and correctly
> selects the individual crypto algorithms, but fails to build when the
> crypto layer is disabled altogether:
>
> crypto/built-in.o: In function `crypto_ctr_free':
> :(.text+0x80): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_rfc3686_free':
> :(.text+0xac): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_ctr_crypt':
> :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block'
> :(.text+0x2f8): undefined reference to `crypto_inc'
>
> To solve that, this patch also selects the core crypto code,
> like all other users of that code do.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Found in ARM randconfig testing
>
> diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig
> index aa462b480a39..b355989c63b3 100644
> --- a/net/mac802154/Kconfig
> +++ b/net/mac802154/Kconfig
> @@ -1,6 +1,7 @@
>   config MAC802154
>   	tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)"
>   	depends on IEEE802154
> +	select CRYPTO
>   	select CRC_CCITT
>   	select CRYPTO_AUTHENC
>   	select CRYPTO_CCM

Good point. I thought that would have been pulled in by CRYPTO_* 
automatically. Nicely spotted.

Reviewed-by: Stefan Schmidt <stefan@....samsung.com>

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html