netdev - Re: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 10:10:33 -0400
From:	Jason Baron <jbaron@...mai.com>
To:	David Miller <davem@...emloft.net>
CC:	edumazet@...gle.com, netdev@...r.kernel.org, ncardwell@...gle.com,
	ycheng@...gle.com
Subject: Re: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory



On 05/19/2015 12:10 AM, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Tue, 19 May 2015 00:09:45 -0400 (EDT)
>
>> From: Jason Baron <jbaron@...mai.com>
>> Date: Fri, 15 May 2015 21:17:07 +0000 (GMT)
>>
>>> From: Jason Baron <jbaron@...mai.com>
>>>
>>> If we really can't get an skb allocated, make sure that we let
>>> userspace know. This at least gives us a chance to re-try or abort.
>>>
>>> Signed-off-by: Jason Baron <jbaron@...mai.com>
>> Applied to net-next, thanks Jason.
> Nevermind, reverted, you didn't compile let alone test this:
>

Hi David,

This was meant as: "do you think this is a good idea? If so, I will
go off and test it. I mentioned it was *not* tested in the separate
thread where we were discussing it:

http://marc.info/?l=linux-netdev&m=143172482802074&w=2

However, I didn't make that at all clear in *this* thread. And I'm
sorry for the inconvenience.

I meant to do:

+       if (unlikely(skb_queue_len(&sk->sk_write_queue) == 0 && err ==
-EAGAIN))
+               sk->sk_write_space(sk);

not:

+       if (unlikely(sk->sk_write_queue == 0 && err == -EAGAIN))
+               sk->sk_write_space(sk);

Sounds like you are ok with doing the wakeup here- so I will go
off and test that approach, and report back my findings.

Thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html