netdev - Re: [PATCH net-next 4/4] rocker: make rocker_port_internal_vlan_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bBURpj6WL4k3Ppwz0a9niSkUcNkCADPLPqbuQ5MrEwUww@mail.gmail.com>
Date:	Tue, 19 May 2015 09:04:10 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}()
 non-transactional

On Mon, May 18, 2015 at 11:24 PM, Simon Horman
<simon.horman@...ronome.com> wrote:
> The motivation for this is that rocker_port_internal_vlan_id_{get,put} appear
> to only partially implement the transaction model: memory allocation
> and freeing is transactional, but hash and bitmap manipulation is not.
>
> The latter could be fixed, however, as it is not currently exercised
> due to trans always being SWITCHDEV_TRANS_NONE it seems cleaner
> to make rocker_port_internal_vlan_id_get non-transactional.
>
> Found by inspection.
> I do not believe that this change should have any run-time effect.
>
> Fixes: c4f20321d968 ("rocker: support prepare-commit transaction model")
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

This works for now.  Once we switch over to using bridge's PVID, we
don't need any of this internal vlan stuff anyway, so eventually most
(all?) of this internal vlan code goes away.

Acked-by: Scott Feldman <sfeldma@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html