netdev - Re: [PATCH net-next 0/4] rocker: transaction fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bAKTw-SPQNqsKsEf_BhXJhqDFPWu6rsgX2=+7Jjh8FL7g@mail.gmail.com>
Date:	Tue, 19 May 2015 09:13:58 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] rocker: transaction fixes

On Mon, May 18, 2015 at 11:24 PM, Simon Horman
<simon.horman@...ronome.com> wrote:
> Hi,
>
> this series addresses what appear to be errors in the handling of
> prepare and then commit transactions in the rocker driver.
>
> In all cases the problem is that data structures visible outside of
> the transaction are modified during the prepare phase.
>
> In the case of the first two patches this results in the kernel reporting a
> BUG. I have noted test-cases in the change logs.
>
> The remaining two patches do not fix bugs that manifest as far as
> I can tell. Rather, they are correctness fixes.
>
> Simon Horman (4):
>   rocker: do not delete fdb entries in rocker_port_fdb_flush() when
>     preparing transactions
>   rocker: do not modify fdb table in rocker_port_fdb() when preparing
>     transactions
>   rocker: do not make neighbour entry changes when preparing
>     transactions
>   rocker: make rocker_port_internal_vlan_id_{get,put}()
>     non-transactional
>
>  drivers/net/ethernet/rocker/rocker.c | 46 ++++++++++++++++++++----------------
>  1 file changed, 25 insertions(+), 21 deletions(-)

Thank you very much Simon for the fixes.  I think for punishment in
missing these I'm going to write unit tests for each.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html