netdev - Re: [PATCH] net-next: ethtool: Added port speed macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGgvQNR-rbqfGVobbo50c_PbSYgNW5f5FXKBg1_GCv=qjDejXQ@mail.gmail.com>
Date:	Tue, 19 May 2015 22:11:05 +0530
From:	Parav Pandit <parav.pandit@...gotech.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bwh@...nel.org
Subject: Re: [PATCH] net-next: ethtool: Added port speed macros.

On Tue, May 19, 2015 at 10:02 PM, David Miller <davem@...emloft.net> wrote:
> From: Parav Pandit <parav.pandit@...gotech.com>
> Date: Tue, 19 May 2015 10:15:49 +0530
>
>> On Mon, May 18, 2015 at 9:16 PM, David Miller <davem@...emloft.net> wrote:
>>> From: Parav Pandit <parav.pandit@...gotech.com>
>>> Date: Mon, 18 May 2015 16:31:47 +0530
>>>
>>>> Signed-off-by: Parav Pandit <parav.pandit@...gotech.com>
>>>
>>> I thought we had decided that we weren't going to keep adding
>>> convenience macros for new speeds, and were simply going to use
>>> the appropriate constants in the future.
>>>
>>
>> I added them to accommodate any speed/PHY interface specific
>> configuration to make use of it.
>> If convenience macros are not needed, I will provide the code cleanup
>> patch to remove existing convenience macros. With that we will have
>> unified code for old and new constants.
>> I will anyway let Ben comment on it.
>
> You cannot remove the existing macros, because they are exported to
> userspace and you'll break application compilation if you do that.

Yes, didn't think about it before.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html