netdev - Re: [PATCH v2] isdn: Use ktime_t instead of 'struct timeval'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6378639.MgDWU7ZGDD@wuerfel>
Date:	Wed, 20 May 2015 15:56:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Tina Ruchandani <ruchandani.tina@...il.com>
Cc:	Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] isdn: Use ktime_t instead of 'struct timeval'

On Tuesday 19 May 2015 13:03:06 Tina Ruchandani wrote:
> 'struct timeval' uses 32-bit representation for seconds which will
> overflow in year 2038 and beyond. mISDN/clock.c needs to compute and
> store elapsed time in intervals of 125 microseconds. This patch replaces
> the usage of 'struct timeval' with 64-bit ktime_t which is y2038 safe.
> The patch also replaces do_gettimeofday() (wall-clock time) with 
> ktime_get() (monotonic time) since we only care about elapsed time here.
> 
> Signed-off-by: Tina Ruchandani <ruchandani.tina@...il.com>
> Suggested-by: Arnd Bergmnann <arnd@...db.de>

Looks mostly ok now, just one detail left:

> +		delta = ktime_us_delta(tv_now, iclock_tv) / 125;

This line is something I suggested, but I have now realized that it's
still wrong, because you introduce a 64-by-32-bit division here
that will fail to link on most 32-bit architectures.

Using a cast to 32-bit value would solve that, like

      delta = ((u32)ktime_us_delta(tv_now, iclock_tv)) / 125;

as that would replace the 64-bit division with a 32-bit division.
This is fine as long as the delta is never more than 71 minutes,
otherwise you have to use

	delta = ktime_divns(ktime_sub(tv_now, iclock_tv), (NS_PER_SEC / 8000));

which is also potentially more efficient.


	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html