netdev - Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520143715.GM9559@gospo.home.greyhouse.net>
Date:	Wed, 20 May 2015 10:37:16 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	roopa@...ulusnetworks.com, john.r.fastabend@...el.com,
	sfeldma@...il.com, john.fastabend@...il.com, jiri@...nulli.us,
	netdev@...r.kernel.org
Subject: Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload
 on failure to program fib entry in hardware

On Tue, May 19, 2015 at 04:28:45PM -0400, David Miller wrote:
> From: Andy Gospodarek <gospo@...ulusnetworks.com>
> Date: Tue, 19 May 2015 15:47:32 -0400
> 
> > Are you actually saying that if users complain loudly enough about
> > the current behavior (not the change Roopa has proposed) that you
> > would be open to considering a change the current behavior?
> 
> I am saying that we have a contract with users not to break existing
> behavior.  Full stop.

I stepped away from the ledge and now definitely agree that the default
behavior should stay the same in the offload or non-offload case.

There is probably room for some level of notification (even if just a
printk) to let one know that offloading is disabled and it would be
great if there was a way to set fib_offload_disabled to false again, but
that's not going to happen until patches are submitted, so I'll get to
that instead of complaining more.  :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html