netdev - Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520060146.GC2228@nanopsycho.orion>
Date:	Wed, 20 May 2015 08:01:46 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	Scott Feldman <sfeldma@...il.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry
 changes when preparing transactions

Wed, May 20, 2015 at 07:48:21AM CEST, simon.horman@...ronome.com wrote:
>rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be
>be called with trans == SWITCHDEV_TRANS_PREPARE and then
>trans == SWITCHDEV_TRANS_COMMIT from switchdev_port_obj_set() via
>fib_table_insert().
>
>The first time that rocker_port_ipv4_nh() is called, with
>trans == SWITCHDEV_TRANS_PREPARE, _rocker_neigh_add() adds a new entry to
>the neigh table.
>
>And the second time  rocker_port_ipv4_nh() is called, with
>trans == SWITCHDEV_TRANS_COMMIT, that entry is found. This causes
>rocker_port_ipv4_nh() to believe it is not adding an entry and thus it
>frees "entry", which is still present in rocker driver's neigh table.
>
>This problem does not appear to affect deletion as my analysis is that
>deletion is always performed with trans == SWITCHDEV_TRANS_NONE.
>
>For completeness _rocker_neigh_{add,del,prepare} are updated not to
>manipulate fib table entries if trans == SWITCHDEV_TRANS_PREPARE.
>
>Fixes: c4f20321d968 ("rocker: support prepare-commit transaction model")
>Reported-by: oshiaki Makita <makita.toshiaki@....ntt.co.jp>
>Acked-by: Scott Feldman <sfeldma@...il.com>
>Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Acked-by: Jiri Pirko <jiri@...nulli.us>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html