netdev - Re: [PATCH v2 net-next 4/4] net: af_unix: implement splice for stream af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432218198.4060.98.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 21 May 2015 07:23:18 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, cwang@...pensource.com
Subject: Re: [PATCH v2 net-next 4/4] net: af_unix: implement splice for
 stream af_unix sockets

On Thu, 2015-05-21 at 11:39 +0200, Hannes Frederic Sowa wrote:
> unix_stream_recvmsg is refactored to unix_stream_read_generic in this
> patch and enhanced to deal with pipe splicing. The refactoring is
> inneglible, we mostly have to deal with a non-existing struct msghdr
> argument.
> 

> +static __always_inline
> +int unix_stream_read_generic(struct unix_stream_read_state *state)
>  {


I do not believe it is reasonable to inline this monster, even if some
macro benchmark looks better.

General trend in the community is to remove all these inlines.

ip_finish_output2() for example should lose its 'inline' keyword.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html