netdev - Re: [PATCH net-next 1/3] net: Flush all skbs related to an unregistered device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150521.170219.1689248066169954260.davem@davemloft.net>
Date:	Thu, 21 May 2015 17:02:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	baptiste@...sta.com
Cc:	netdev@...r.kernel.org, fruggeri@...sta.com, mowat@...sta.com,
	adrien+dev@...ischi.me
Subject: Re: [PATCH net-next 1/3] net: Flush all skbs related to an
 unregistered device

From: Baptiste Covolato <baptiste@...sta.com>
Date: Tue, 19 May 2015 16:24:51 -0700

> Update flush_backlog to flush all packets in the backlog queue belonging
> to a device being unregistered. Accordingly on_each_cpu no longer needs
> to pass a device to flush_backlog since it handles any device in the
> NETREG_UNREGISTERED state.
> 
> Signed-off-by: Baptiste Covolato <baptiste@...sta.com>
> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>

This is quite bogus if you ask me.

This is the one spot causing a device to make the transition
to unregistered state, so passing that specific device to
flush_backlog() is the completely logical way to handle this.

If this is some hack that is made necessary by your parallel
notification scheme, I do not find it acceptable.

I'm not applying this series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html