netdev - Re: [PATCH] qlge: Move jiffies_to_usecs immediately before loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150521.172335.2013762602695904530.davem@davemloft.net>
Date:	Thu, 21 May 2015 17:23:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	harish.patil@...gic.com, sudarsana.kalluru@...gic.com,
	Dept-GELinuxNICDev@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qlge: Move jiffies_to_usecs immediately before loop

From: Joe Perches <joe@...ches.com>
Date: Tue, 19 May 2015 21:44:52 -0700

> 30 usecs (or really, 1 jiffy) can go by pretty fast.
> 
> Move the set of the timeout immediately before the loop.
> 
> Remove the unnecessary max(1ul, usecs_to_jiffies(30)) as
> usecs_to_jiffies with a non-zero constant is guaranteed
> to be non-zero.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

This looks fine, applied to net-next, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html