netdev - Re: [PATCH net] ipv4: Avoid crashing in ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e2509a329a821ca67e9a7fc55b54aa5@vittgam.net>
Date:	Fri, 22 May 2015 17:12:09 +0200
From:	"Vittorio G (VittGam)" <linuxbugs@...tgam.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<security@...nel.org>, Greg KH <greg@...ah.com>,
	<luto@...capital.net>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH net] ipv4: Avoid crashing in ip_error

Il 22.05.2015 14:08 Eric Dumazet ha scritto:
> On Fri, 2015-05-22 at 04:58 -0500, Eric W. Biederman wrote:
>> ip_error does not check if in_dev is NULL before dereferencing it.
>
>>
>> Therefore handle this weird case by just dropping the packet if
>> !in_dev.  It will result in dropping the packet sooner, and will not
>> result in an actual change of behavior.
>>
>> Fixes: 251da4130115b ("ipv4: Cache ip_error() routes even when not forwarding.")
>> Reported-by: "Vittorio G (VittGam)" <linuxbugs@...tgam.net>
>> Tested-by: "Vittorio G (VittGam)" <linuxbugs@...tgam.net>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>> ---
>
> Acked-by: Eric Dumazet <edumazet@...gle.com>
>
> Thanks !

I've no problem using my real name here, so:

Reported-by: Vittorio Gambaletta <linuxbugs@...tgam.net>
Tested-by: Vittorio Gambaletta <linuxbugs@...tgam.net>
Signed-off-by: Vittorio Gambaletta <linuxbugs@...tgam.net>

Signed-off too, since this is actually v2 of my patch with the warning removed.

Thanks!
Vittorio
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html