netdev - Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 May 2015 10:53:39 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Neil McKee <neil.mckee@...on.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] openvswitch: include datapath actions with
 sampled-packet upcall to userspace

On Wed, May 20, 2015 at 12:32 PM, Neil McKee <neil.mckee@...on.com> wrote:
> Directly associate a sampled packet with the path it takes through the virtual switch.
> Path information currently includes mangling, encapsulation and decapsulation actions
> for tunneling protocols GRE, VXLAN, Geneve, MPLS and QinQ, but this extension requires
> no further changes to accommodate datapath actions that may be added in the future.
>
> Adding path information enhances visibility into complex virtual networks.
>
> Signed-off-by: Neil McKee <neil.mckee@...on.com>
> ---
>  net/openvswitch/actions.c  | 14 +++++++++-----
>  net/openvswitch/datapath.c | 18 ++++++++++++++++++
>  net/openvswitch/datapath.h |  2 ++
>  3 files changed, 29 insertions(+), 5 deletions(-)
>
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index b491c1c..ee5760d 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -608,7 +608,8 @@ static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port)
>  }
>
>  static int output_userspace(struct datapath *dp, struct sk_buff *skb,
> -                           struct sw_flow_key *key, const struct nlattr *attr)
> +                           struct sw_flow_key *key, const struct nlattr *attr,
> +                           const struct nlattr *actions, int actions_len)
>  {
>         struct ovs_tunnel_info info;
>         struct dp_upcall_info upcall;
> @@ -619,6 +620,8 @@ static int output_userspace(struct datapath *dp, struct sk_buff *skb,
>         upcall.userdata = NULL;
>         upcall.portid = 0;
>         upcall.egress_tun_info = NULL;
> +       upcall.actions = actions;
> +       upcall.actions_len = actions_len;
>
Rather than unconditionally passing actions to the upcall, there
should be attribute in ovs_userspace_attr to request the actions list.

>         for (a = nla_data(attr), rem = nla_len(attr); rem > 0;
>                  a = nla_next(a, &rem)) {
> @@ -654,7 +657,8 @@ static int output_userspace(struct datapath *dp, struct sk_buff *skb,
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html