netdev - Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150522.145636.734827115116283588.davem@davemloft.net>
Date:	Fri, 22 May 2015 14:56:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@...3.blue
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, stephen@...workplumber.org,
	herbert@...dor.apana.org.au, roopa@...ulusnetworks.com,
	cwang@...pensource.com, sashok@...ulusnetworks.com,
	wkok@...ulusnetworks.com
Subject: Re: [PATCHv2 net-next] bridge: allow setting hash_max +
 multicast_router if interface is down

From: Linus Lüssing <linus.luessing@...3.blue>
Date: Fri, 22 May 2015 15:32:37 +0200

> @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, unsigned long val)
>  	case 1:
>  		br->multicast_router = val;
>  		err = 0;
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}

Please don't remove the break; statement.

> @@ -1827,14 +1817,8 @@ int br_multicast_set_port_router(struct net_bridge_port *p, unsigned long val)
>  			break;
>  
>  		br_multicast_add_router(br, p);
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}
>  
> -unlock:
>  	spin_unlock(&br->multicast_lock);
>  
>  	return err;

Likewise.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html