netdev - Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150522.161511.1791346966770946099.davem@davemloft.net>
Date:	Fri, 22 May 2015 16:15:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aparames@...adcom.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com, rjui@...adcom.com,
	sbranden@...adcom.com, jdzheng@...adcom.com
Subject: Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy
 settings

From: Arun Parameswaran <aparames@...adcom.com>
Date: Wed, 20 May 2015 14:35:30 -0700

> When trying to configure the settings for PHY1, using commands
> like 'ethtool -s eth0 phyad 1 speed 100', the 'ethtool' seems to
> modify other settings apart from the speed of the PHY1, in the
> above case.
> 
> The ethtool seems to query the settings for PHY0, and use this
> as the base to apply the new settings to the PHY1. This is
> causing the other settings of the PHY 1 to be wrongly
> configured.
> 
> The issue is caused by the '_ethtool_get_settings()' API, which
> gets called because of the 'ETHTOOL_GSET' command, is clearing
> the 'cmd' pointer (of type 'struct ethtool_cmd') by calling
> memset. This clears all the parameters (if any) passed for the
> 'ETHTOOL_GSET' cmd. So the driver's callback is always invoked
> with 'cmd->phy_address' as '0'.
> 
> The '_ethtool_get_settings()' is called from other files in the
> 'net/core'. So the fix is applied to the 'ethtool_get_settings()'
> which is only called in the context of the 'ethtool'.
> 
> Signed-off-by: Arun Parameswaran <aparames@...adcom.com>
> Reviewed-by: Ray Jui <rjui@...adcom.com>
> Reviewed-by: Scott Branden <sbranden@...adcom.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html