netdev - [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432334609-3971-1-git-send-email-aparames@broadcom.com>
Date:	Fri, 22 May 2015 15:43:27 -0700
From:	Arun Parameswaran <aparames@...adcom.com>
To:	Ben Hutchings <bwh@...nel.org>
CC:	<netdev@...r.kernel.org>, <jdzheng@...adcom.com>,
	<aparames@...adcom.com>
Subject: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

Hi,
The patch fixes 2 issues with 'ethtool' getting/setting parametres in
the do_gset() do_sset() API's.

I have pushed a patch to the Kernel to fix an issue in the handling of
the 'ethtool' commands which got accepted.
This Kernel patch was based on Linux v4.1-rc4 and is available in:
https://github.com/Broadcom/cygnus-linux/tree/net-core-ethtool-fix-v1

The Kernel was always clearing the command from the 'ethtool' resulting
in all operations to deal with PHY0. This prevents querying/setting
PHY 1's settings.

The first patch is required due to the fact that Kernel will not be
clearing the command data structure. Without this the query will fail
as the command will get to the Kernel with arbitary phyad info.

The second patch is to fix the issue in which the 'ethtool' gets the
settings of the wrong phyad before applying the new settings.

These changes will still work with older Kernel's (as the Kernel
clears the command data structure).

Thanks

Arun Parameswaran (2):
  ethtool: Clear the command data structure before sending requests
  ethtool: Fix an issue with handling 'phyad' while updating settings

 ethtool.c |    9 +++++++++
 1 file changed, 9 insertions(+)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html