netdev - Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150523092708.GA23152@tonks>
Date:	Sat, 23 May 2015 11:27:08 +0200
From:	Florian Bruhin <me@...-compiler.org>
To:	David Miller <davem@...emloft.net>
Cc:	bjorn@...k.no, netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	oliver@...kum.org, ben.hutchings@...ethink.co.uk
Subject: Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

* David Miller <davem@...emloft.net> [2015-05-22 14:34:21 -0400]:
> From: Bjørn Mork <bjorn@...k.no>
> Date: Fri, 22 May 2015 13:15:22 +0200
> 
> > The tx_curr_frame_payload field is u32. When we try to calculate a
> > small negative delta based on it, we end up with a positive integer
> > close to 2^32 instead.  So the tx_bytes pointer increases by about
> > 2^32 for every transmitted frame.
> > 
> > Fix by calculating the delta as a signed long.
> > 
> > Cc: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> > Reported-by: Florian Bruhin <me@...-compiler.org>
> > Fixes: 7a1e890e2168 ("usbnet: Fix tx_bytes statistic running backward in cdc_ncm")
> > Signed-off-by: Bjørn Mork <bjorn@...k.no>
> 
> Applied and queued up for -stable.

Thank you, and thanks Bjørn for the quick fix!

Florian

-- 
http://www.the-compiler.org | me@...-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
         I love long mails! | http://email.is-not-s.ms/

Content of type "application/pgp-signature" skipped