[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1432415349.4060.136.camel@edumazet-glaptop2.roam.corp.google.com>
Date: Sat, 23 May 2015 14:09:09 -0700
From: Eric Dumazet <eric.dumazet@...il.com>
To: Julian Anastasov <ja@....bg>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>,
David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
"Vittorio G (VittGam)" <linuxbugs@...tgam.net>,
security@...nel.org, Greg KH <greg@...ah.com>, luto@...capital.net,
Willy Tarreau <w@....eu>
Subject: Re: [PATCH net] ipv4: Avoid crashing in ip_error
On Sat, 2015-05-23 at 21:48 +0300, Julian Anastasov wrote:
> Hello,
>
> On Sat, 23 May 2015, Eric W. Biederman wrote:
>
> > Perhaps it is possible to transmit into a veth pair even when the
> > carrier is down? Which could be a bug in the veth driver.
>
> Not sure if that can help but both RCU_INIT_POINTER
> calls in veth_dellink can be before the unregister_netdevice_queue
> ones. May be it will help for the case when veth_dellink is
> called with head=NULL. As result, veth_xmit will free all
> flying skbs to peer that is unregistered first.
Good point, but note that we never call dellink() method with head==NULL
in current kernels.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists