lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 May 2015 07:50:25 +0200 From: Nicholas Mc Guire <der.herr@...r.at> To: David Miller <davem@...emloft.net> Cc: hofrat@...dl.org, samuel@...tiz.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: use msecs_to_jiffies for conversion to jiffies On Sun, 24 May 2015, David Miller wrote: > From: Nicholas Mc Guire <hofrat@...dl.org> > Date: Sat, 23 May 2015 15:43:36 +0200 > > > API compliance scanning with coccinelle flagged: > > ./net/irda/timer.c:63:35-37: use of msecs_to_jiffies probably perferable > > > > Converting milliseconds to jiffies by "val * HZ / 1000" technically > > is not a clean solution as it does not handle all corner cases correctly. > > By changing the conversion to use msecs_to_jiffies(val) conversion is > > correct in all cases. Further the () around the arithmetic expression > > was dropped. > > > > Patch was compile tested for x86_64_defconfig + CONFIG_IRDA=m > > > > Patch is against 4.1-rc4 (localversion-next is -next-20150522) > > > > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org> > > The appropriate subsystem prefix for this change is not "net: " > but rather "irda: ", please update your Subject line accordingly > and resubmit. > sorry - the net: cam from looking at the output of hofrat@...ian:~/git/linux-next$ git log --oneline net/irda/timer.c d82603c treewide: Replace incomming with incoming in all comments and strings 9ffc93f Remove all #inclusions of asm/system.h 25985ed Fix common misspellings 5eaa65b net: Make static db955170 more UTF-8 conversions 6819bc2 [NET] IRDA: Fix whitespace errors. 6ab3d56 Remove obsolete #include <linux/config.h> where it was not really clear what prefix to use - and net: seemed the most fitting. will fix it up and resend. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists