netdev - Re: [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150525191447.GV18303@xsjsorenbubuntu>
Date:	Mon, 25 May 2015 12:14:47 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Nathan Sullivan <nathan.sullivan@...com>
CC:	<nicolas.ferre@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

On Fri, 2015-05-22 at 09:22AM -0500, Nathan Sullivan wrote:
> Use the new zynq binding for macb ethernet, since it will disable half
> duplex gigabit like the Zynq TRM says to do.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index a5cd2ed..9ea54b3 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -193,7 +193,7 @@
>  		};
>  
>  		gem0: ethernet@...0b000 {
> -			compatible = "cdns,gem";
> +			compatible = "cdns,zynq-gem";

Please, prepend the new string to the compatible list. Don't just
replace it like this.

>  			reg = <0xe000b000 0x1000>;
>  			status = "disabled";
>  			interrupts = <0 22 4>;
> @@ -204,7 +204,7 @@
>  		};
>  
>  		gem1: ethernet@...0c000 {
> -			compatible = "cdns,gem";
> +			compatible = "cdns,zynq-gem";

ditto

	Sören
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html