lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 May 2015 16:36:17 -0400 (EDT) From: David Miller <davem@...emloft.net> To: shailendra.capricorn@...il.com Cc: 3chas3@...il.com, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] atm:he - Do not initialise statics to 0. From: Shailendra Verma <shailendra.capricorn@...il.com> Date: Tue, 26 May 2015 01:23:53 +0530 > Static variables are initialised to 0 by GCC. > Fixes the following checkpatch error: > ERROR: do not initialise statics to 0 or NULL > FILE: drivers/atm/he.c:120: > static bool sdh = 0; > > Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com> true is not necessarily '1' and false is not necessarily '0', therefore the correct fix would be to assign 'false' to this variable. Furthermore you've submitted this in such a way that it cannot be applied alongside the other atm:he patch you submitted. This is why when you submit multiple patches to the same file, you must group them and submit them relative to eachother and in a specific order. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists