netdev - Re: [PATCH net-next v5 2/2] net: Adding support for Cavium ThunderX network controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150525.173348.561751759043903433.davem@davemloft.net>
Date:	Mon, 25 May 2015 17:33:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aleksey.makarov@...iumnetworks.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, david.daney@...ium.com,
	robert.richter@...iumnetworks.com, sgoutham@...ium.com,
	mjc@...ihalf.com, ganapatrao.kulkarni@...iumnetworks.com,
	tomasz.nowicki@...aro.org, rrichter@...ium.com, kamil@...ihalf.com,
	tsrinivasulu@...iumnetworks.com, svangala@...ium.com,
	rric@...nel.org
Subject: Re: [PATCH net-next v5 2/2] net: Adding support for Cavium
 ThunderX network controller

From: Aleksey Makarov <aleksey.makarov@...iumnetworks.com>
Date: Fri, 22 May 2015 18:28:16 -0700

> +#ifdef NOT_SUPPORTED_FOR_NOW
> +static int nicvf_set_coalesce(struct net_device *netdev,
> +			      struct ethtool_coalesce *cmd)
> +{
 ...
> +#ifdef NOT_SUPPORTED_FOR_NOW
> +	.set_coalesce		= nicvf_set_coalesce,
> +#endif
> +	.get_ringparam		= nicvf_get_ringparam,

Remove this completely.  When you actually make it work and want to
enable it, you can re-add the code.

The upstream kernel is not your personal workspace :-)

> +#ifdef VNIC_RSS_SUPPORT

This is unconditionally defined in one of your headers, please remove
these ifdefs as they will never be false.

> +#ifdef VNIC_RSS_SUPPORT

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html