netdev - Re: [PATCH v2 net-next 1/3] net: Add cache alignment in sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432662883.4060.279.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 26 May 2015 10:54:43 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/3] net: Add cache alignment in sock_common
 for socket lookup fields

On Tue, 2015-05-26 at 10:19 -0700, Eric Dumazet wrote:

> No, we do not want to increase the size of sock_common with such a
> hammer.

Current sizeof(struct sock_common) is 0x78 bytes.

So moving 2 read_mostly pointers into this structure would be enough to
make 2 first cache lines read mostly.

One candidate would be sk_rx_dst, as it is used in early demux.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html