netdev - Re: [PATCH net-next 1/1] tipc: fix bug in link protocol message create function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150526.194342.115254427393620467.davem@davemloft.net>
Date:	Tue, 26 May 2015 19:43:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 1/1] tipc: fix bug in link protocol message
 create function

From: Jon Maloy <jon.maloy@...csson.com>
Date: Tue, 26 May 2015 05:40:19 -0400

> In commit dd3f9e70f59f43a5712eba9cf3ee4f1e6999540c
> ("tipc: add packet sequence number at instant of transmission") we
> made a change with the consequence that packets in the link backlog
> queue don't contain valid sequence numbers.
> 
> However, when we create a link protocol message, we still use the
> sequence number of the first packet in the backlog, if there is any,
> as "next_sent" indicator in the message. This may entail unnecessary
> retransissions or stale packet transmission when there is very low
> traffic on the link.
> 
> This commit fixes this issue by only using the current value of
> tipc_link::snd_nxt as indicator.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html