netdev - Re: [PATCH net-next] tcp: fix/cleanup inet_ehash_locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150526.194858.341347965444056849.davem@davemloft.net>
Date:	Tue, 26 May 2015 19:48:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix/cleanup inet_ehash_locks_alloc()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 26 May 2015 07:55:34 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> If tcp ehash table is constrained to a very small number of buckets
> (eg boot parameter thash_entries=128), then we can crash if spinlock
> array has more entries.
> 
> While we are at it, un-inline inet_ehash_locks_alloc() and make
> following changes :
> 
> - Budget 2 cache lines per cpu worth of 'spinlocks'
> - Try to kmalloc() the array to avoid extra TLB pressure.
>   (Most servers at Google allocate 8192 bytes for this hash table)
> - Get rid of various #ifdef
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html