netdev - RE: [PATCH 4/5] stmmac: add ipq806x glue layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 09:10:16 -0700
From:	"Mathieu Olivari" <mathieu@...eaurora.org>
To:	"'Paul Bolle'" <pebolle@...cali.nl>
Cc:	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<mturquette@...aro.org>, <sboyd@...eaurora.org>,
	<peppe.cavallaro@...com>, <agross@...eaurora.org>,
	<joshc@...eaurora.org>, <architt@...eaurora.org>,
	<georgi.djakov@...aro.org>, <wsa@...-dreams.de>,
	<rnayak@...eaurora.org>, <davem@...emloft.net>,
	<vbridger@...nsource.altera.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH 4/5] stmmac: add ipq806x glue layer

My bad. This is ISC license. MODULE_LICENSE should actually be "Dual BSD/GPL".
Same license is used in other places in the kernel like drivers/net/wireless/ath/ath10k/pci.c.
I'll post a v2.
Thanks,
Mathieu

-----Original Message-----
From: Paul Bolle [mailto:pebolle@...cali.nl] 
Sent: Wednesday, May 27, 2015 12:04 AM
To: Mathieu Olivari
Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com; ijc+devicetree@...lion.org.uk; galak@...eaurora.org; mturquette@...aro.org; sboyd@...eaurora.org; peppe.cavallaro@...com; agross@...eaurora.org; joshc@...eaurora.org; architt@...eaurora.org; georgi.djakov@...aro.org; wsa@...-dreams.de; rnayak@...eaurora.org; davem@...emloft.net; vbridger@...nsource.altera.com; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-clk@...r.kernel.org; netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] stmmac: add ipq806x glue layer

Just a nit: a license mismatch.

On Tue, 2015-05-26 at 12:27 -0700, Mathieu Olivari wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c

> + * Permission to use, copy, modify, and/or distribute this software 
> + for any
> + * purpose with or without fee is hereby granted, provided that the 
> + above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL 
> + WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE 
> + LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY 
> + DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN 
> + AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING 
> + OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

I have no idea which license this is.

> +MODULE_LICENSE("GPL");

But I do know that it's not GPL v2 or later (see include/linux/module.h).


Paul Bolle


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html